This repository was archived by the owner on Oct 12, 2021. It is now read-only.
feat(AppShell): shellRender and shellNoRender attributes and allow different element stripping strategies#81
Open
mgechev wants to merge 1 commit intoangular:masterfrom
Open
Conversation
9e2c349 to
34e3399
Compare
Member
Author
|
Fixes #71. |
cc3259d to
d92257b
Compare
Member
Author
|
Note that in a browser environment, the DOM adapter needs to be explicitly set: import { BrowserDomAdapter } from '@angular/platform-browser/src/browser/browser_adapter';
BrowserDomAdapter.makeCurrent(); |
823e18a to
2c18098
Compare
…t different stripping strategies - [x] Make the shell-related directives add `shellRender` and `shellNoRender` attributes. - [x] Encapsulate the "hiding", "showing" element logic into a service which is injected with DI and can its provider can be overridden. - [x] Add visitor which finds App Shell related comments in templates and processes them. - [x] Remove useless imports.
2c18098 to
ec90574
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shellRenderandshellNoRenderattributes.