Add support for parsing chapters from MKV files#3144
Open
tymmesyde wants to merge 16 commits intoandroidx:mainfrom
Open
Add support for parsing chapters from MKV files#3144tymmesyde wants to merge 16 commits intoandroidx:mainfrom
tymmesyde wants to merge 16 commits intoandroidx:mainfrom
Conversation
icbaker
reviewed
Mar 27, 2026
Collaborator
icbaker
left a comment
There was a problem hiding this comment.
I can't work out how to delete the stale comment made against an old copy of the code, sorry for the duplication.
libraries/extractor/src/main/java/androidx/media3/extractor/mkv/MatroskaExtractor.java
Show resolved
Hide resolved
libraries/extractor/src/main/java/androidx/media3/extractor/mkv/MatroskaExtractor.java
Outdated
Show resolved
Hide resolved
srgsf
approved these changes
Mar 28, 2026
srgsf
left a comment
There was a problem hiding this comment.
I'm not sure how to resolve threads, everything is correct now.
ffed640 to
938fa38
Compare
And some other stylistic changes
9b1c258 to
c11d749
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this include changes to support parsing MKV chapters using the recent changes to introduce metadata Chapter interface
This is already implemented for MP4: Nero & QuickTime
Used this doc as reference: https://www.matroska.org/technical/elements.html
Added
sample_with_chapters.mkvformkvSample_withChapterstestGenerated with: