Repository navigation
Conversation
Colombia ATDC needs a stable AMP client id on each ad request. Register AMP_ECID_COLOMBIA and forward context.clientId on the vendor payload. Co-authored-by: Cursor <cursoragent@cursor.com>
Use site-user-id-cookie-fallback-name so atdcUid matches colanalytics val_122.
|
Hi @calebcordry / AMP team, Could you please review PR #40566? It has been open for around few days, and the following checks are still pending. The CLA is already signed, and the remaining checks have passed. Please let me know if any changes are required from our side. Thanks. |
|
Hi @calebcordry @camelburrito / AMP team, Could you please review PR #40566? It has been open for around few days, and the following checks are still pending. The CLA is already signed, and the remaining checks have passed. Please let me know if any changes are required from our side. Thanks. |
|
Hi @calebcordry / AMP team / @ampprojectbot , Could you please review PR #40566? It has been open for around few days, and the following checks are still pending. The CLA is already signed, and the remaining checks have passed. Please let me know if any changes are required from our side. Thanks. |
|
Hi @calebcordry — could you please take a look at this PR when you have a moment? It adds a stable client ID (atdcUid) for Colombia ads (ads/_config.js and ads/vendors/colombia.js). Could you also approve the pending GitHub Actions workflows and Percy check so CI can complete? Thanks! |
|
Hi @powerivq — I noticed you’ve handled most of the recent ad-vendor additions in ads/_config.js, so looping you in directly since @calebcordry hasn’t been active recently. This PR (#40566) is a small, 6-line change to add a stable atdcUid client ID for Colombia ads. All 44 code/test checks are green (CircleCI, bundle-size, CodeQL, Codecov), CLA is signed, and the branch is up to date with main. What’s left is entirely review-gated: ampproject/owners-check needs an approving review from wg-ads-reviewers Would really appreciate a look when you have a moment — happy to make any changes needed. Thanks! |
|
Hi @erwinmombay All checks are passing — would appreciate a review when you get a chance. Thanks! |
Summary
Colombia ads need a stable client id on each ad request, so the same browser can be recognized across page views.
colombiaad type. AMP only setscontext.clientIdwhen that scope is present.atdcUid, with-0000000appended.If the scope is missing,
context.clientIdis null andatdcUidis sent empty.Test plan
<amp-ad type="colombia">and confirm the ad frame receives a client id.atdcUidas{clientId}-0000000.