Skip to content

✨ Pass a stable client id to Colombia ads as atdcUid - #40566

Open
pshkumarr wants to merge 3 commits into
ampproject:mainfrom
pshkumarr:colombia-atdc-client-id
Open

pshkumarr wants to merge 3 commits into
ampproject:mainfrom
pshkumarr:colombia-atdc-client-id

Conversation

@pshkumarr

Copy link
Copy Markdown

Summary

Colombia ads need a stable client id on each ad request, so the same browser can be recognized across page views.

  • Register a client id scope for the colombia ad type. AMP only sets context.clientId when that scope is present.
  • Send the resolved id to the Colombia ad script as atdcUid, with -0000000 appended.

If the scope is missing, context.clientId is null and atdcUid is sent empty.

Test plan

  • Load an AMP page with <amp-ad type="colombia"> and confirm the ad frame receives a client id.
  • Confirm the Colombia ad payload includes atdcUid as {clientId}-0000000.
  • Reload the page and confirm the same id is returned.

pshkumarr and others added 2 commits October 8, 2026 13:06
Colombia ATDC needs a stable AMP client id on each ad request.
Register AMP_ECID_COLOMBIA and forward context.clientId on the vendor payload.

Co-authored-by: Cursor <cursoragent@cursor.com>
Use site-user-id-cookie-fallback-name so atdcUid matches colanalytics val_122.
@CLAassistant

CLAassistant commented Oct 22, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@pshkumarr

Copy link
Copy Markdown
Author

Hi @calebcordry / AMP team,

Could you please review PR #40566? It has been open for around few days, and the following checks are still pending.

The CLA is already signed, and the remaining checks have passed. Please let me know if any changes are required from our side.

Thanks.

@pshkumarr

Copy link
Copy Markdown
Author

Hi @calebcordry @camelburrito / AMP team,

Could you please review PR #40566? It has been open for around few days, and the following checks are still pending.

The CLA is already signed, and the remaining checks have passed. Please let me know if any changes are required from our side.

Thanks.

@pshkumarr

Copy link
Copy Markdown
Author

Hi @calebcordry / AMP team / @ampprojectbot ,

Could you please review PR #40566? It has been open for around few days, and the following checks are still pending.

The CLA is already signed, and the remaining checks have passed. Please let me know if any changes are required from our side.

Thanks.

@pshkumarr

Copy link
Copy Markdown
Author

Hi @calebcordry — could you please take a look at this PR when you have a moment? It adds a stable client ID (atdcUid) for Colombia ads (ads/_config.js and ads/vendors/colombia.js). Could you also approve the pending GitHub Actions workflows and Percy check so CI can complete? Thanks!

@pshkumarr

Copy link
Copy Markdown
Author

Hi @powerivq — I noticed you’ve handled most of the recent ad-vendor additions in ads/_config.js, so looping you in directly since @calebcordry hasn’t been active recently.

This PR (#40566) is a small, 6-line change to add a stable atdcUid client ID for Colombia ads. All 44 code/test checks are green (CircleCI, bundle-size, CodeQL, Codecov), CLA is signed, and the branch is up to date with main. What’s left is entirely review-gated:

ampproject/owners-check needs an approving review from wg-ads-reviewers
percy/amphtml needs the 1 visual-diff build approved
2 GitHub Actions workflow runs are awaiting maintainer approval

Would really appreciate a look when you have a moment — happy to make any changes needed.

Thanks!

@deepakmishracolombia

Copy link
Copy Markdown

Hi @erwinmombay All checks are passing — would appreciate a review when you get a chance. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants