Repository navigation
🐛 fix substring cache-origin check in getTemplateProxyUrl_ - #40560
Open
mrdevel2002-ui wants to merge 2 commits into
Open
mrdevel2002-ui wants to merge 2 commits into
mrdevel2002-ui wants to merge 2 commits into
Conversation
|
|
Author
|
gentle ping |
Member
|
looking |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTemplateProxyUrl_ decides whether an a4a template URL is already on the AMP cache with
loc.origin.indexOf(cdnUrlSuffix) > 0, so any origin that merely containscdn.ampproject.orgpasses and the URL gets fetched as-is instead of being rewritten to the cache proxy form. templateUrl comes straight out of the ad server JSON response (TemplateValidator.validateandAmpAdNetworkAdzerkImpl.maybeValidateAmpCreative), so a creative can point it athttps://cdn.ampproject.org.adserver.example/t.htmland have arbitrary HTML from its own origin parsed by getAmpAdMetadata and rendered as the creative in the friendly iframe, which is a plain suffix-confusion bypass of the host check (the fetch ismode: cors, credentials: omit, so the attacker host only needs an ACAO header). isProxyOrigin() anchors the origin against cdnProxyRegex and still accepts both the bare cache host and the<publisher>.cdn.ampproject.orgform, so legitimate template URLs behave exactly as before; the added test pins the lookalike host to the proxy rewrite.