Conversation
amazon-ec2-net-utils.spec
Outdated
| @@ -54,7 +55,7 @@ setup_interfaces() { | |||
| unset ID_NET_DRIVER | |||
| eval $(udevadm info --export --query=property /sys/class/net/$iface) | |||
| case $ID_NET_DRIVER in | |||
| ena|ixgbevf|vif) | |||
| ena|ixgbevf|vif|mlx5_core) | |||
There was a problem hiding this comment.
Fyi this may not be necessary and optional because it applies tuning parameters to the kernel.
This has not been tested widely in all instances and not guaranteed to work on your drivers.
There was a problem hiding this comment.
Makes sense, it seemed like it wouldn't change much so I included. Although I believe lines 68 and 69 restarting and refreshing the policy routes are necessary for our case.
There was a problem hiding this comment.
The new 80-ec2-secondary.network only has DHCP=ipv4, UseGateway, and UseMTU, while the existing 80-ec2.network includes a bunch of other settings. Is the reduced config intentional for mlx5 devices? If so, could you document the reasoning?
There was a problem hiding this comment.
It was intentional as it seemed like those settings were specifically for ena optimizations.
However, reading more it seems like they can be helpful for mlx5 as well (excluding DHCPv6 settings as we currently only support v4). I've included and retested them now
Avtesh29
force-pushed
the
feature/mlx5-support
branch
from
fbf69d1 to
e79baef
Compare
We need to recognize a new device type on our instances. This device type should be automatically brought up and able to query IMDS for multiple IPs as is the case for ena. To do this we: Create a separate network file for mlx5 devices and add the mlx5_core driver type to the match for policy routes. Testing: - Built and installed rpm/deb packages for AL2023/Ubuntu respectively - Launched AL2023/Ubuntu with package installed into ami - For fresh instance, install on existing instance, and reboot --> validated that we see multiple IPs and the correct MTU of 8500 for each secondary interface
Avtesh29
force-pushed
the
feature/mlx5-support
branch
from
e79baef to
e39967d
Compare
3 participants
Issue #142
Creates a separate network file for mlx5 devices. Adds the mlx5_core driver type to the match for policy routes.
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.