Skip to content

Replace hardcoded hostname in ping tests#705

Open
MatthiasKunnen wants to merge 1 commit into
amacneil:mainfrom
MatthiasKunnen:dynamic-hostname-ping-tests
Open

Replace hardcoded hostname in ping tests#705
MatthiasKunnen wants to merge 1 commit into
amacneil:mainfrom
MatthiasKunnen:dynamic-hostname-ping-tests

Conversation

@MatthiasKunnen

Copy link
Copy Markdown

When testing with a custom MYSQL_TEST_URL, these tests would otherwise fail.

@dossy

dossy commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

@MatthiasKunnen Could you please rebase this change on top of the latest main and see if the CI tests pass?

@dossy dossy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI test currently failing, I think because this PR needs the changes from #727 and #731 merged in.

@dossy dossy added go Pull requests that update Go code needs work labels Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code needs work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants