Fix missing shared Vite chunk in recovered Linux bundle#6
Closed
meetpandya4715 wants to merge 1 commit intoam-will:mainfrom
Closed
Fix missing shared Vite chunk in recovered Linux bundle#6meetpandya4715 wants to merge 1 commit intoam-will:mainfrom
meetpandya4715 wants to merge 1 commit intoam-will:mainfrom
Conversation
Owner
|
i'll try to fix this for you. i already merged new versions so let me take a look thx |
Owner
|
fix should be in. let me know if its not, please reopen PR if you have an issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a Linux startup crash caused by an incomplete recovered desktop bundle.
The committed recovered bundle under:
desktop/recovered/app-asar-extracted/.vite/buildwas missing the shared chunk:
product-name-BA584x_m.jsBoth
bootstrap.jsandmain-BnI_RVTn.jsrequire that file, so the packaged Linux app dies during Electron main-process startup with:Root Cause
The Linux port vendors a recovered upstream desktop payload, but the recovered
.vite/builddirectory in git is incomplete for26.415.20818.The matching official upstream desktop payload contains the missing chunk, while this repo’s recovered bundle only included:
bootstrap.jsmain-BnI_RVTn.jspreload.jsworker.jsThat is enough to satisfy current tests, but not enough to satisfy runtime module resolution.
What This PR Changes
desktop/recovered/app-asar-extracted/.vite/build/product-name-BA584x_m.jsrequire("./*.js")dependencies in the recovered.vite/builddirectory actually exist.vite/build/*.jsfiles can be intentionally vendored when the upstream runtime requires themWhy This Fix
This is the smallest change that makes the Linux package boot again without changing runtime behavior.
The file is already part of the matching upstream desktop payload for this version; it was just omitted from the vendored recovered bundle.
Verification
Before:
bootstrap.jsrequiring./product-name-BA584x_m.jsAfter:
Test run:
Result:
14 passedNotes
This PR intentionally does not change the port’s architecture or packaging strategy.
It restores the missing upstream runtime artifact and adds a guardrail so future recovered bundle refreshes catch the same class of issue earlier.