Skip to content

billing: fetch gcp services#852

Merged
tituscarl merged 12 commits intomainfrom
gcpservicelist
Apr 8, 2026
Merged

billing: fetch gcp services#852
tituscarl merged 12 commits intomainfrom
gcpservicelist

Conversation

@Ricz2024
Copy link
Copy Markdown
Contributor

@Ricz2024 Ricz2024 commented Apr 8, 2026

No description provided.

@Ricz2024 Ricz2024 requested review from tituscarl and topphh April 8, 2026 03:55
@tituscarl
Copy link
Copy Markdown
Collaborator

@Ricz2024 what does this new RPC do?

@Ricz2024
Copy link
Copy Markdown
Contributor Author

Ricz2024 commented Apr 8, 2026

@Ricz2024 what does this new RPC do?

@tituscarl ListGCPServices retrieves the list of available GCP services (service code, service ID, display names, and SKUs) stored in DynamoDB. It is intended to be used as a reference when creating a GCP exclude service entry via CreateExcludeServiceEntry, so the caller knows what valid GCP service codes and SKUs are available to exclude.

@tituscarl
Copy link
Copy Markdown
Collaborator

@Ricz2024 for AWS is it available?

@Ricz2024
Copy link
Copy Markdown
Contributor Author

Ricz2024 commented Apr 8, 2026

@Ricz2024 for AWS is it available?

for AWS I've hardcoded it

@tituscarl
Copy link
Copy Markdown
Collaborator

Is this a new feature? if not, how does previous implementation retrieves the list?

@tituscarl
Copy link
Copy Markdown
Collaborator

We cannot hardcode for GCP?

Comment thread billing/v1/billing.proto Outdated
@Ricz2024
Copy link
Copy Markdown
Contributor Author

Ricz2024 commented Apr 8, 2026

It’s not totally new since it’s already implemented in CSTool, and we plan to make it a feature in Ripple.

We cannot hardcode for GCP?

We could hardcode GCP services, but I don't have a definitive list of which services need to be available for exclusion and that list may vary. That is why I created this RPC to dynamically retrieve the data from the RIPPLE table using the sort key prefixtype|sdkey_sku|vendor|gcp|service_code|, so the caller always gets an up-to-date list of available GCP services to choose from when creating an exclude service entry.

@Ricz2024 Ricz2024 requested a review from topphh April 8, 2026 05:00
@tituscarl
Copy link
Copy Markdown
Collaborator

I see, how does CSTool implement it? The list service part

@Ricz2024
Copy link
Copy Markdown
Contributor Author

Ricz2024 commented Apr 8, 2026

@tituscarl, same as this, I’ve created an API to get the list.

@tituscarl
Copy link
Copy Markdown
Collaborator

Wait, so there is an existing API same like this one? but not in blue?

@Ricz2024
Copy link
Copy Markdown
Contributor Author

Ricz2024 commented Apr 8, 2026

@tituscarl yes but its only available for CSTool.

Comment thread billing/v1/billing.proto Outdated
Comment thread billing/v1/billing.proto Outdated
Comment thread billing/v1/billing.proto Outdated
Comment thread billing/v1/billing.proto Outdated
@Ricz2024 Ricz2024 requested review from tituscarl and topphh April 8, 2026 05:31
Comment thread billing/v1/billing.proto Outdated
Comment thread billing/v1/billing.proto
Comment thread billing/v1/billing.proto Outdated
@Ricz2024 Ricz2024 requested a review from tituscarl April 8, 2026 06:29
tituscarl
tituscarl previously approved these changes Apr 8, 2026
@tituscarl
Copy link
Copy Markdown
Collaborator

@flowerinthenight if you have time, can you please also take a look? thanks!

Comment thread billing/v1/billing.proto Outdated
Comment thread billing/v1/billing.proto Outdated
@topphh topphh requested a review from Copilot April 8, 2026 06:43
@topphh topphh review requested due to automatic review settings April 8, 2026 06:44
@tituscarl tituscarl merged commit 1574298 into main Apr 8, 2026
6 checks passed
@tituscarl tituscarl deleted the gcpservicelist branch April 8, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants