fix(plugin-testops): Align the upload payload with the backend contract - #889
Closed
todti wants to merge 1 commit into
Closed
fix(plugin-testops): Align the upload payload with the backend contract#889todti wants to merge 1 commit into
todti wants to merge 1 commit into
Conversation
Three defects found by comparing what the plugin uploads against what the TestOps API accepts. They are independent of each other. Global errors come from the results files test framework adapters write, and their message is optional in our model — nothing validates it on the way in. TestOps requires a non-blank message and rejects the entire bulk request when one item lacks it, so a single untitled error dropped every valid error uploaded alongside it. Send a placeholder instead, keeping the trace. This became easier to hit once every not-yet-uploaded error started being sent rather than only the last one. TestOps accepts a launch name of at most 255 characters and fails the request otherwise, so a longer report title killed the upload before it started. Trim the name to the accepted length. The upload API has no `environment` property on a test result, so the value was dropped on arrival; the binding it was meant to carry travels in `namedEnv`, which is sent next to it. Remove the dead field from the payload and from the type that mirrors the API.
todti
force-pushed
the
fix/testops-payload-gaps
branch
from
August 25, 2026 17:22
c27adb0 to
54ce38f
Compare
Allure Report Summary
|
Allure perf metricsGenerated at:
Artifacts: allure-perf-metrics |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Three defects found by comparing what the plugin uploads against what the TestOps API accepts. They are independent of each other and of #888, which fixes the
ciblock of the same request.A blank error message rejects the whole batch. Global errors come from the results files test framework adapters write, and their message is optional in our model — nothing validates it on the way in. TestOps requires a non-blank message and rejects the entire bulk request when one item lacks it, so a single untitled error dropped every valid error uploaded alongside it. A placeholder is sent instead, keeping the trace. This became easier to hit once every not-yet-uploaded error started being sent rather than only the last one.
A long launch name fails launch creation. TestOps accepts a launch name of at most 255 characters and fails the request otherwise, so a longer report title killed the upload before it started. The name is trimmed to the accepted length now.
environmentwas sent into the void. The upload API has noenvironmentproperty on a test result, so the value was dropped on arrival; the binding it was meant to carry travels innamedEnv, which is sent next to it. The dead field is gone from the payload and from the type that mirrors the API.Checklist