fix: publish plugin-allure2 static assets in npm package - #783
Open
grootstebozewolf wants to merge 3 commits into
Open
fix: publish plugin-allure2 static assets in npm package#783grootstebozewolf wants to merge 3 commits into
grootstebozewolf wants to merge 3 commits into
Conversation
Include ./static in the package files list so single- and multi-file report generation can resolve template manifests after npm install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./staticin@allurereport/plugin-allure2package.jsonfilesso published packages ship the template assets used at runtime.readTemplateManifestfor single and multi modes.Fixes #601
Context
Report generation resolves
static/{single|multi}/manifest.jsonfrom the package root. With only./distpublished, npm installs hit ENOENT and only producesummary.json.Test plan
npm pack --dry-runinpackages/plugin-allure2listsstatic/single/manifest.jsonandstatic/multi/manifest.jsonyarn workspace @allurereport/plugin-allure2 test(package-layout tests pass)allure generatewith allure2 plugin (single + multi) producesindex.htmlwithout ENOENT on static paths