Keep per-environment test results in history data points (fixes #503) - #765
Open
tjulioh wants to merge 4 commits into
Open
Keep per-environment test results in history data points (fixes #503)#765tjulioh wants to merge 4 commits into
tjulioh wants to merge 4 commits into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #503.
When filtering the Status Dynamics graph by environment, only the current data point was correct. All earlier points showed mixed results from all environments.
#377 fixed the read side, but the write side was still losing data: createHistoryItems keys history test results by historyId, which doesn't include the environment. So when the same test runs in several environments, only the last one gets saved to the history file.
Changes:
core-api: new composeHistoryTestResultKey(historyId, environment) helper. Default environment keeps the plain historyId (backward compatible), other environments use historyId::.
core: createHistoryItems now writes one entry per test and environment. allNewTestResults and #historyByTr were updated to handle the new keys, with fallback to plain keys for old history files.
web-commons: generateStatusAgePyramid and generateStabilityDistributionChart now try the environment key first, then the plain one.
Old history files are still readable. Points written before this fix stay incomplete since the environment info was lost at write time, but new points are saved correctly.