Fix some compilation warnings [neogb/msolve]#297
Open
vneiger wants to merge 4 commits intoalgebraic-solving:masterfrom
Open
Fix some compilation warnings [neogb/msolve]#297vneiger wants to merge 4 commits intoalgebraic-solving:masterfrom
vneiger wants to merge 4 commits intoalgebraic-solving:masterfrom
Conversation
Contributor
|
I will have a look asap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
-Wall -Wextra -Wno-sign-compare -Wno-unused-parameterto the Makefile of theneogbandmsolvecomponents, and makes small fixes in the code to solve all the warnings that appeared.None of the warnings revealed an actual issue, just one remains (at least on gcc with avx2):
@mohabsafey could you please have a look to make sure
!= NULLis what you meant?