Fix bug shape position#294
Merged
mohabsafey merged 3 commits intoalgebraic-solving:masterfrom Mar 14, 2026
Merged
Conversation
…f the ideal is in shape position, whether it is radical or not
… runs of FGLM to verify the parametrizations
Contributor
|
Many thanks. Do we have a test for this (non-radical ideal but in shape position)? |
Contributor
Author
|
Yes, we do: there is one called nonradical-shape. There is also a new one that is not radical and requires a linear form called x2y2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of a comparison error, when the ideal is not radical but in shape position, msolve was introducing a linear form in order to compute the parametrization of the solution.
This PR fixes this and add
make checktests for this.As a side effect, the example of issue #284 is not reproducible anymore as the ideal is actually in shape position.
Likewise, the test
diff_choice-linear-form-qq.shis actually an example in shape position and so does not test what it was introduced for. As a consequence, it has been deactivated.