Skip to content

Fix real root isolation when sizeof(long)==4 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohabsafey merged 1 commit into from
Mar 12, 2026
Merged

Fix real root isolation when sizeof(long)==4 #292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/usolve/refine.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,12 @@ static long long int index_linearinterp(mpz_t *vala, mpz_t *valb, mpz_t *q,
}
return -1;
}
#if ULONG_MAX == ULLONG_MAX
long long int index = mpz_get_ui(*q);
#else
long long int index = 0;
mpz_export(&index, NULL, 1, sizeof(index), 0, 0, *q);
#endif
return index;
}

Expand Down Expand Up @@ -305,8 +310,17 @@ static void refine_root_by_N_positive_k(mpz_t *upol, unsigned long int *deg_ptr,
mpz_mul_2exp(rt->numer, rt->numer, Nlog);

if(index >= 0){
#if ULONG_MAX == ULLONG_MAX
getx_and_eval_2exp(upol, *deg_ptr, &(rt->numer),x, vala, q,
newk, index);
#else
mpz_t index_tmp;
mpz_init(index_tmp);
mpz_import(index_tmp, 1, 1, sizeof(index), 0, 0, &index);
getx_and_eval_2exp_mpzidx(upol, *deg_ptr, &(rt->numer), x, vala, q,
newk, &index_tmp);
mpz_clear(index_tmp);
#endif
}
else{
getx_and_eval_2exp_mpzidx(upol, *deg_ptr, &(rt->numer), x, vala, q,
Expand Down Expand Up @@ -446,8 +460,17 @@ static void refine_root_by_N_negative_k(mpz_t *upol, unsigned long int *deg_ptr,
}

if(index >= 0){
#if ULONG_MAX == ULLONG_MAX
getx_and_eval(upol, *deg_ptr, &(rt->numer), x, vala, q,
Nlog, k, index);
#else
mpz_t index_tmp;
mpz_init(index_tmp);
mpz_import(index_tmp, 1, 1, sizeof(index), 0, 0, &index);
getx_and_eval_mpzidx(upol, *deg_ptr, &(rt->numer),x, vala, q,
Nlog, k, &index_tmp);
mpz_clear(index_tmp);
#endif
}
else{
getx_and_eval_mpzidx(upol, *deg_ptr, &(rt->numer),x, vala, q,
Expand Down
Loading