Switch to analytics.Pass for type metadata

[NathanBaulch]

Significant type resolution improvement by switching to the standard analysis.Pass metadata. Previously this type information was only available for custom types defined within the file being analyzed. This PR also allows us to remove the naive type inference code in types.go.

[alexkohler]

TIL about analytics.Pass - thanks!

[NathanBaulch]

I should probably mention @alexkohler that this represents a breaking API change that will require upstream changes in golangci-lint. I don't fully understand how the determination is made but I believe deep type analysis puts us in the "slow" category of linters. IMO this is fine since prealloc is off by default (and generally not recommended), so it's something users already opt into.
Just thought you should take this into consideration when you tag the next release.

[alexkohler]

I should probably mention @alexkohler that this represents a breaking API change that will require upstream changes in golangci-lint. I don't fully understand how the determination is made but I believe deep type analysis puts us in the "slow" category of linters. IMO this is fine since prealloc is off by default (and generally not recommended), so it's something users already opt into. Just thought you should take this into consideration when you tag the next release.

Thank for flagging this. AIUI, the workaround here would be to have golang-ci-lint to use v1.0.3 (per our other thread), is that right?

[NathanBaulch]

In the short term, yes. Dependabot should detect this new v1.0.3 tag and pull it into golangci-lint upstream shortly. For the next release I recommend incrementing to v1.1.0 to signal an API change that will need human intervention (likely myself) in golangci-lint.

[alexkohler]

Got it, thanks. I tagged/pushed v1.1.0 at 2108c81 (current HEAD of master).