Disqualify graph traversal for loops - #70
Merged
Merged
Conversation
alexkohler
approved these changes
Feb 12, 2026
Owner
Agree! Thanks again for all of the PRs + improving prealloc 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following is a common pattern for traversing linked lists or tree node ancestors:
for n := first(); n != nil; n = n.next() {There's no way to determine the iteration count statically for for loops that advance the loop variable with a function call, so these need to be disqualified.
At some point I'd like to enable the
--forloopsoption by default once we can reliably handle these common for loop patterns.