fix: remove duplicate test:frontmatter script key#217
Open
PathGao wants to merge 1 commit into
Open
Conversation
package.json declared "test:frontmatter" twice; JSON parsing keeps the last key, so the variant covering only scripts/frontMatter.test.ts silently shadowed the one that also runs scripts/frontMatterDisclosure.test.ts. Keep the complete variant so both test files run under npm run test:frontmatter. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsondeclares thetest:frontmatterscript twice:When JSON is parsed, the last duplicate key wins, so the second entry silently shadows the first —
scripts/frontMatterDisclosure.test.tsis never executed bynpm run test:frontmatter. This PR removes the second (narrower) entry and keeps the one that runs both test files.Verification
Ran
npm run test:frontmatterlocally after the change: 11 tests pass, 0 fail — including the 3 disclosure-panel tests fromfrontMatterDisclosure.test.tsthat were previously skipped.🤖 Generated with Claude Code