Name bootler as the only supervisor consumer - #86
Merged
Conversation
The module doc said two consumers install these units -- bootler onto the hosts it provisions, and roxyd join onto the hosts it onboards, where bootler never runs. The join-only installer subcommand shipped afterwards and does the opposite: roxyd join invokes it on a pre-placed payload-free bootler-security, so bootler installs onto both populations and roxyd is not a consumer of this module. That was worth more than a stale sentence, because it is the stated reason the text takes no parameters -- an argument from having to be byte-identical across two populations said to install it by two different routes. The reason survives and so does the decision; only the count of consumers was wrong, and the doc now records that an earlier revision said the reverse so the correction is not undone by someone reading the old rationale. Fix a second sentence in the same direction. The namespace-free /opt/roxyd/bin/roxyd path was explained by a join host having no namespace to resolve. It has one -- it arrives as an explicit argument and is persisted into the per-host sink. The path is namespace-free because it is the agent own path and roxyd is one per host, not a namespaced product component. Closes #85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the module documentation on
src/roxyd_selfupdate.rs, which names the reverse of what now runs. Doc comments only — no API, no behaviour, no test changes.What was wrong
The doc said two consumers install the supervisor units: bootler onto the hosts it provisions, and roxyd
joinonto the hosts it onboards, "where bootler never runs and so cannot place anything". The join-only installer subcommand shipped afterwards and does the opposite —roxyd joininvokesbootler-security roxyd-supervisor-installon a pre-placed payload-free binary — so bootler installs onto both populations and roxyd is not a consumer of this module.That is worth correcting rather than living with, because it is the stated reason the text takes no parameters: the argument runs from having to be byte-identical across two populations said to install it by two different routes. The reason survives intact and so does the decision — only the count of consumers was wrong. The correction records that an earlier revision said the reverse, so it is not undone by someone reading the old rationale.
A second sentence was wrong the same way: the namespace-free
/opt/roxyd/bin/roxydpath was explained by a join host having "no namespace to resolve". It has one — it arrives as an explicitroxyd join --namespace <ns>argument and is persisted into the per-host sink. The path is namespace-free because it is the agent own path and roxyd is one per host, not a namespaced product component.Verification
cargo checkpasses.Closes #85