Conversation
frodre
commented
May 18, 2026
| ) | ||
| elif fine_coordinates_path is not None: | ||
| return load_coords_from_path(fine_coordinates_path) | ||
| return load_coords_from_path(fine_coordinates_path).to(get_device()) |
Collaborator
Author
There was a problem hiding this comment.
To make consistent with the other coordinate loading pathway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the latest main with our published HiRO ckpt revealed that
CheckpointModelConfigwith provided fine coordinates path crashed with mismatched devices for theLatLonCoordinates.__eq__check, which is enforced during building (prior to device coercing in theDiffusionModel.__init__).This is a specific case of a model checkpoint with an intermediate old style format that can no longer be created. However, I felt that the equality shouldn't be what fails since the equality is a value check.