Switch proto generation to BSR export#6
Merged
Merged
Conversation
Contributor
Author
Test & Lint SummaryCommands:
Tests: passed 18, failed 0, skipped 0 |
Contributor
Author
Summary
Test & Lint SummaryCommands:
Tests: passed 18, failed 0, skipped 0 |
noa-lucent
approved these changes
Mar 10, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, focused PR that matches the notifications service pattern exactly.
All six requirements from #5 are met:
- Local proto sources removed
- Dockerfile, CI, and release workflows updated with
buf exportbeforebuf generate - Makefile updated
.gitignoreentry preserved with improved comment- Go code updated to use renamed
TokenCountingModelenum constants - No stale references to old
Model_MODEL_*names remain
No issues found. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Ref: #5