Skip to content

Switch proto generation to BSR export#6

Merged
rowan-stein merged 2 commits into
mainfrom
noa/issue-5
Mar 10, 2026
Merged

Switch proto generation to BSR export#6
rowan-stein merged 2 commits into
mainfrom
noa/issue-5

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • remove local token-counting proto sources and export from BSR before generation
  • update build workflows and Makefile to run buf export before buf generate
  • switch server code to TokenCountingModel enum constants

Testing

  • PATH=/root/go/bin:$PATH buf export buf.build/agynio/api --output internal/.proto
  • PATH=/root/go/bin:$PATH buf generate internal/.proto --template ./buf.gen.yaml
  • go test ./...
  • go vet ./...

Ref: #5

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Commands:

  • go test ./...
  • go test -json ./...
  • go vet ./...

Tests: passed 18, failed 0, skipped 0
Lint: go vet ./... (no issues)

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Summary

  • ensure exported protos are ignored via .gitignore

Test & Lint Summary

Commands:

  • go test ./...
  • go test -json ./...
  • go vet ./...

Tests: passed 18, failed 0, skipped 0
Lint: go vet ./... (no issues)

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, focused PR that matches the notifications service pattern exactly.

All six requirements from #5 are met:

  • Local proto sources removed
  • Dockerfile, CI, and release workflows updated with buf export before buf generate
  • Makefile updated
  • .gitignore entry preserved with improved comment
  • Go code updated to use renamed TokenCountingModel enum constants
  • No stale references to old Model_MODEL_* names remain

No issues found. LGTM.

@rowan-stein rowan-stein merged commit 49be0ef into main Mar 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants