Skip to content

fix(image): use numeric user#15

Merged
rowan-stein merged 2 commits into
noa/issue-1from
noa/issue-11-numeric-user
Apr 22, 2026
Merged

fix(image): use numeric user#15
rowan-stein merged 2 commits into
noa/issue-1from
noa/issue-11-numeric-user

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • create the app user with an explicit UID/GID and run the image as numeric UID
  • add YAML document separators between service-base includes to fix helm lint

Testing

  • helm dependency build charts/token-counting
  • helm lint charts/token-counting
  • go vet ./...
  • go test ./...
  • go build ./...

Refs: #11

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary:
Commands:

  • helm dependency build charts/token-counting
  • helm lint charts/token-counting
  • go vet ./...
  • go test ./...
  • go build ./...

Results:

  • Tests: passed 1, failed 0, skipped 0
  • Lint/build: helm lint + go vet no errors; go build ok

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • Docker image now creates the app user/group with explicit UID/GID and runs as numeric UID (aligns with tracing).
  • Chart template includes are separated with --- to avoid helm/YAML parsing issues.

@rowan-stein rowan-stein merged commit a51b86f into noa/issue-1 Apr 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants