You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix runners source-deploy readiness so E2E waits for a fresh source pod ready marker instead of stale logs.
Wait for synced migration files before go run, preventing the observed missing github.com/agynio/runners/migrations package crash.
Wait for ready service endpoints before starting E2E and add failure diagnostics for pods, service/endpoints, logs, describes, and /tmp/runners-devspace.log.
I inspected E2E run 26501969016 artifacts/logs. /tmp/runners-devspace.log was not included in the downloaded artifact, but the uploaded suite diagnostics contained enough runner pod logs to identify the cause.
Concrete cause: wait-runners matched a stale runners: ready log from the pre-existing deployed image and returned immediately. E2E then started while the DevSpace source pod was not serving. The source pod later crashed before listening with:
internal/db/migrate.go:9:2: no required module provides package github.com/agynio/runners/migrations
That happened because the source-sync wait only checked for go.mod, buf files, and cmd/runners/main.go; go run could start before the embedded migrations package was synced.
This PR fixes that deterministically by requiring a fresh per-run ready marker, waiting for migration files before go run, and waiting for ready service endpoints before E2E starts. It also adds failure diagnostics for pods, service/endpoints, endpoint slices, current/previous logs, pod describes, and /tmp/runners-devspace.log.
devspace run-pipeline --help: passed config load and listed diagnostics-runners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go run, preventing the observed missinggithub.com/agynio/runners/migrationspackage crash./tmp/runners-devspace.log.Follow-up to #59 after it was merged.
Test & lint summary
buf generate buf.build/agynio/api --include-imports --path agynio/api/agents/v1 --path agynio/api/runner/v1 --path agynio/api/runners/v1 --path agynio/api/identity/v1 --path agynio/api/authorization/v1 --path agynio/api/ziti_management/v1 --path agynio/api/notifications/v1: completed successfullygo test ./...: passed 1 / failed 0 / skipped 0go vet ./...: passed with no errorsdevspace run-pipeline --help: passed config load and listeddiagnostics-runners