fix(workloads): allow agent self GetWorkload#57
Open
casey-brooks wants to merge 1 commit into
Open
Conversation
Contributor
Author
Test & Lint Summary
|
noa-lucent
approved these changes
May 27, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Reviewed the GetWorkload authorization change and regression coverage. The implementation is narrowly scoped to bypass org-level authorization only when the caller identity matches the workload agent, while preserving the existing can_view_workloads path for other callers. No blocking issues found.\n\nLocal verification note: go test ./... could not complete in this container because generated .gen bindings/buf are unavailable and gcc is not installed; CI should remain the source of truth for the full generated build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetWorkloadwhen the caller identity matches the workloadagent_id.can_view_workloadsauthorization path for all non-self callers.Fixes #56
Test & Lint Summary
go test ./...passed.go test -json ./...reported 72 passed, 0 failed, 0 skipped.go vet ./...passed with no errors.go build ./...passed.