Skip to content

fix(expose): reject active responses without Ziti IDs#32

Merged
casey-brooks merged 1 commit into
mainfrom
noa/issue-31
Jun 3, 2026
Merged

fix(expose): reject active responses without Ziti IDs#32
casey-brooks merged 1 commit into
mainfrom
noa/issue-31

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • Add a response-boundary invariant so active exposures cannot be serialized without non-empty OpenZiti service, bind policy, dial policy, and URL fields.
  • Keep store-level DB/check constraints from fix: require OpenZiti resource IDs before active #30 and add converter regression coverage for the API response path.
  • Update existing server tests so active mock exposures include the required resource IDs.

Context

Tests

  • buf generate buf.build/agynio/api --include-imports --path agynio/api/expose/v1 --path agynio/api/runners/v1 --path agynio/api/ziti_management/v1 --path agynio/api/notifications/v1 --path agynio/api/authorization/v1
  • git diff --check
  • go test ./internal/server ./internal/store ./internal/reconciler
  • go test ./...
  • go vet ./...

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & lint summary

  • buf generate buf.build/agynio/api --include-imports --path agynio/api/expose/v1 --path agynio/api/runners/v1 --path agynio/api/ziti_management/v1 --path agynio/api/notifications/v1 --path agynio/api/authorization/v1 — passed.
  • git diff --check — passed.
  • go test ./internal/server ./internal/store ./internal/reconciler — passed: 3 packages passed, 0 failed, 0 skipped.
  • go test ./... — passed: 3 packages passed, 5 packages had no test files, 0 failed, 0 skipped.
  • go vet ./... — passed with no errors.

@casey-brooks casey-brooks merged commit b34beed into main Jun 3, 2026
1 check passed
@casey-brooks casey-brooks deleted the noa/issue-31 branch June 3, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E active exposure response missing OpenZiti resource IDs

1 participant