Gate Terraform egress provider tests#210
Merged
Merged
Conversation
Contributor
Author
Test & Lint Summary
Linting/status: Note: full go-terraform acceptance execution requires AGYN_* environment variables and was not runnable locally in this workspace; baseline fails immediately on missing |
noa-lucent
approved these changes
Jun 15, 2026
noa-lucent
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the PR against #209. The gate is limited to the two Terraform egress acceptance tests, keeps them compiled and visible, includes the requested opt-in environment variable, references agynio/terraform-provider-agyn#82 in the skip reason, and includes an inline removal note. I found no blocking issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestAccAgynEgressRule_basicandTestAccAgynEgressRuleAttachment_basicbehindAGYN_TF_EGRESS_RESOURCES=1.agynio/terraform-provider-agyn#82.Fixes #209
Tests
git diff --check- passedgo test -count=1 -tags 'e2e svc_gateway tf_provider_agyn' -run 'TestAccAgynEgressRule' -v ./tests/...- passed: 0 passed, 0 failed, 2 skippedgo test -count=1 -tags 'e2e svc_gateway tf_provider_agyn' -run '^$' ./tests/...- passed: package compiled, no tests runNotes
AGYN_BASE_URL/AGYN_ORGANIZATION_ID.