Skip to content

Gate Terraform egress provider tests#210

Merged
rowan-stein merged 1 commit into
mainfrom
noa/issue-209
Jun 15, 2026
Merged

Gate Terraform egress provider tests#210
rowan-stein merged 1 commit into
mainfrom
noa/issue-209

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • Gate only TestAccAgynEgressRule_basic and TestAccAgynEgressRuleAttachment_basic behind AGYN_TF_EGRESS_RESOURCES=1.
  • Keep the Terraform egress tests compiled and visible with an explicit skip reason referencing agynio/terraform-provider-agyn#82.
  • Added an inline removal note for when provider egress resources ship.
  • No Playwright egress coverage was changed.

Fixes #209

Tests

  • git diff --check - passed
  • go test -count=1 -tags 'e2e svc_gateway tf_provider_agyn' -run 'TestAccAgynEgressRule' -v ./tests/... - passed: 0 passed, 0 failed, 2 skipped
  • go test -count=1 -tags 'e2e svc_gateway tf_provider_agyn' -run '^$' ./tests/... - passed: package compiled, no tests run

Notes

  • Full go-terraform acceptance execution requires AGYN_* environment variables and was not runnable locally in this workspace; baseline fails immediately on missing AGYN_BASE_URL / AGYN_ORGANIZATION_ID.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • git diff --check - passed with no whitespace errors.
  • go test -count=1 -tags 'e2e svc_gateway tf_provider_agyn' -run 'TestAccAgynEgressRule' -v ./tests/... - passed: 0 passed, 0 failed, 2 skipped.
  • go test -count=1 -tags 'e2e svc_gateway tf_provider_agyn' -run '^$' ./tests/... - passed: package compiled, no tests run.

Linting/status: gofmt was run on the changed Go file; git diff --check passed with no errors.

Note: full go-terraform acceptance execution requires AGYN_* environment variables and was not runnable locally in this workspace; baseline fails immediately on missing AGYN_BASE_URL / AGYN_ORGANIZATION_ID.

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR against #209. The gate is limited to the two Terraform egress acceptance tests, keeps them compiled and visible, includes the requested opt-in environment variable, references agynio/terraform-provider-agyn#82 in the skip reason, and includes an inline removal note. I found no blocking issues.

@rowan-stein rowan-stein merged commit 5c6ff78 into main Jun 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gate Terraform egress provider tests until provider resources ship

3 participants