feat(ziti-management): add service reconcile RPCs#146
Conversation
Test & Lint Summary
|
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Test & lint summary
This is the API contract PR being used by agynio/ziti-management#61 for agynio/ziti-management#60 and agynio/architecture#152. |
rowan-stein
left a comment
There was a problem hiding this comment.
CI (buf) is green; approving.
172acaa to
70f50f5
Compare
|
Fixed the buf failure on api#146. Commit:
Summary:
Validation:
CI:
|
|
Rechecked the reported buf failure. The cited run Current schema compatibility in
Validation rerun:
Current CI:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Review complete. The proto changes cover the ziti-management service reconciliation contract and preserve the existing UpdateService wire fields while adding the structured Service response under reconciled_service. The new create return_existing fields and get/list service/service-policy RPCs match the downstream implementation needs. Buf PR CI is green for this head.
Local check: git diff --check passed. buf is not installed in this container, so I relied on the successful buf-pr workflow for lint/breaking validation.
Summary
return_existingflags to service and service policy create requests for idempotent recovery.Tracking issue: agynio/ziti-management#60
Test & Lint Summary
buf lint: passed with no errors.buf breaking --against '.git#branch=main': passed with no breaking changes.