fix(gemini): group parallel tool responses#2353
Open
Zbhbb wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Gemini function-calling formatting by ensuring multiple tool results produced in a single tool message are emitted as a single Content(role="user"), matching Gemini’s contract for parallel function responses.
Changes:
- Buffer
ToolResultBlockconversions perMsgand emit one groupeduserContentcontaining allFunctionResponseparts in original order. - Preserve existing conversion behavior for non-tool blocks while keeping tool responses separated into their own
Content. - Add a regression test covering two tool results in one message.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.../GeminiMessageConverter.java |
Groups tool-result parts from a single Msg into one user Content instead of emitting one per ToolResultBlock. |
.../GeminiMessageConverterTest.java |
Adds a test asserting two tool results become one user Content with two FunctionResponse parts in order. |
Zbhbb
force-pushed
the
codex/gemini-tool-response-grouping
branch
from
July 22, 2026 08:52
75acb34 to
58a81cb
Compare
Zbhbb
force-pushed
the
codex/gemini-tool-response-grouping
branch
from
July 22, 2026 08:56
58a81cb to
82b4e3f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…g' into codex/gemini-tool-response-grouping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gemini expects responses to parallel function calls in one
userContent. Previously, the formatter emitted one Content perToolResultBlock, which can split a valid parallel tool-response batch.This change buffers tool-result parts while converting one
Msg, then emits oneuserContent containing the ordered function responses.Changes
Testing
mvn -pl agentscope-extensions/agentscope-extensions-model/agentscope-extensions-model-gemini -am -q -Dtest=GeminiMessageConverterTest -Dsurefire.failIfNoSpecifiedTests=false testmvn -pl agentscope-extensions/agentscope-extensions-model/agentscope-extensions-model-gemini -am -q testmvn -pl agentscope-extensions/agentscope-extensions-model/agentscope-extensions-model-gemini -q spotless:checkgit diff --checkCloses #2351
Checklist