fix(tool): use call-scoped group activation#2333
Open
YingchaoX wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
YingchaoX
force-pushed
the
fix/2169-tool-group-auth
branch
from
July 21, 2026 05:34
d8d78ae to
1951708
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.1-SNAPSHOT
Description
Closes #2169.
Tool schemas exposed to the model are filtered using the active tool groups stored in the call-scoped
ToolContextState. However, tool execution authorization previously checked the shared activation flags inToolGroupManager.When multiple sessions used different tool-group states, a tool could therefore be exposed to the model but rejected during execution with an
Unauthorized tool callerror.This PR makes schema filtering and execution authorization use the same call-scoped state:
ToolGroupManager.isActiveTooloverload that evaluates explicitly supplied active group names.AgentStateinToolExecutorand authorizes grouped tools usingToolContextState.getActivatedGroups().Validation:
mvn spotless:applymvn testgit diff --checkNo documentation changes are required because this fixes internal authorization-state consistency without changing the public API or documented usage.
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)