Skip to content

fix(import): align wrappers with current CLI flags#1044

Open
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/import-wrapper-cli-contract
Open

fix(import): align wrappers with current CLI flags#1044
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/import-wrapper-cli-contract

Conversation

@RerankerGuo

Copy link
Copy Markdown
Contributor

Summary

  • stop Bash and PowerShell import wrappers from advertising or forwarding flags that the current hiclaw CLI does not implement
  • document structured mcpServers configuration through YAML and align English/Chinese examples
  • add a recording regression test for supported forwarding, unsupported rejection, and wrapper help

Root cause

The wrappers lagged behind the current Go CLI contract after its apply/import behavior changed. They still accepted --mcp-servers, --dry-run, and --prune, so users only saw a failure after the arguments reached the container CLI.

Validation

  • PWSH_BIN=/tmp/powershell-7.6.3/pwsh install/tests/test-import-wrapper-contract.sh (14 passed, 0 failed; baseline was 2 passed, 8 failed)
  • existing import package tests with PR fix(test): update import mock Manager name #1034 applied (6 passed, 0 failed)
  • bash -n install/hiclaw-import.sh install/hiclaw-apply.sh install/tests/test-import-wrapper-contract.sh
  • shellcheck -S warning install/hiclaw-import.sh install/hiclaw-apply.sh install/tests/test-import-wrapper-contract.sh
  • PowerShell AST parse
  • go run ./cmd/hiclaw apply worker --help confirms the removed flags are absent
  • git diff --check

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr-2 / mgr=copaw / wk=copaw)

Commit: 910287c
Workflow run: #1669

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction-2 / mgr=copaw / wk=copaw)

Commit: 910287c
Workflow run: #1669

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=copaw / wk=copaw)

Commit: 910287c
Workflow run: #1669

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr / mgr=openclaw / wk=openclaw)

Commit: 910287c
Workflow run: #1669

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr / mgr=copaw / wk=copaw)

Commit: 910287c
Workflow run: #1669

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=copaw / wk=hermes)

Commit: 910287c
Workflow run: #1669

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=openclaw / wk=openclaw)

Commit: 910287c
Workflow run: #1669

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction-2 / mgr=copaw / wk=hermes)

Commit: 910287c
Workflow run: #1669

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction-2 / mgr=openclaw / wk=openclaw)

Commit: 910287c
Workflow run: #1669

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr / mgr=copaw / wk=hermes)

Commit: 910287c
Workflow run: #1669

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@RerankerGuo

Copy link
Copy Markdown
Contributor Author

CI attribution for run #1669: translation, change detection, the controller/base build, and all six downstream image builds passed.

I audited the raw logs for all 10 failed integration jobs. Each job has an empty AGENTTEAMS_LLM_API_KEY, exits from install-embedded with LLM API Key is required, and records no test-start marker. The logs contain no hiclaw-import invocation, so none of the changed wrapper paths ran. This is the same base-workflow secret bootstrap issue addressed by #1026; no branch-specific code change is warranted here.

The focused local contract regression remains green (14 passed, 0 failed), including Bash and PowerShell behavior.

@shiyiyue1102

Copy link
Copy Markdown
Collaborator

The wrapper and CLI contract alignment is useful, and the focused Bash and PowerShell regression passes locally. The remaining blocker is the current required CI result: ten integration jobs are still recorded as failed. Please update or rebase the branch onto the latest main branch and rerun the required checks. If the failures still occur before tests start because of CI credentials, link the new run and its evidence; otherwise address the failing paths before final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants