Skip to content

fix(release): validate without publishing-token authority - #739

Merged
imran-siddique merged 1 commit into
agentrust-io:mainfrom
dinakarjs:fix/release-validation-no-oidc
Oct 8, 2026
Merged

imran-siddique merged 1 commit into
agentrust-io:mainfrom
dinakarjs:fix/release-validation-no-oidc

Conversation

@dinakarjs

@dinakarjs dinakarjs commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

The release validation job added in #722 and its called CI test job both have id-token: write for Codecov. This repeats the issue identified in the cA2A review: tests can mint release-context OIDC tokens before the publishing job, while source alone cannot establish PyPI environment protections.

Use a credential-free mirror of CI for release validation, including manual build-only rehearsals. Preserve every CI job/step except coverage upload and its OIDC grant; an exact parity regression test prevents drift. Ordinary CI keeps authenticated coverage reporting, with release contexts excluded. Only the publish job retains release OIDC authority. The artifact handoff, explicit manual publication choice, exact version-tag guard and post-publication governance remain in place.

Follow-up to the AgenTrust release audit scope in .github#54 and the requested review change at agentrust-io/ca2a#235 (review). Draft for maintainer review of applying that ruling to cMCP.

Validation on main 9deea16, Linux/Python 3.12: 2,434 passed, 29 skipped, 89.78% coverage across the normal CI directories. The focused permission/parity test and Ruff across src/tests pass. Remote CI (including its Linux/Windows Python matrix), CodeQL, Workflow lint and Confinement reference checks now pass on ae88b37. Actual release artifact execution remains untested on this revision. No publishing workflow was dispatched.

Signed-off-by: Srinivasa Dinakar <dinakarjs@gmail.com>
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Contributor Check: MEDIUM

Check Result
Profile MEDIUM
Credential LOW
Overall MEDIUM

Automated check by AgenTrust Contributor Check.

@github-actions github-actions Bot added the needs-review:MEDIUM Contributor check flagged MEDIUM risk label Oct 8, 2026
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@imran-siddique
imran-siddique marked this pull request as ready for review October 8, 2026 19:46
@imran-siddique
imran-siddique merged commit 5d09f31 into agentrust-io:main Oct 8, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review:MEDIUM Contributor check flagged MEDIUM risk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants