Repository navigation
feat(sdk): add Step.children - #282
Merged
namrataghadi-galileo merged 2 commits intoOct 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jasmine-ab-tea
approved these changes
Oct 6, 2026
wrisa
approved these changes
Oct 6, 2026
jasmine-ab-tea
approved these changes
Oct 6, 2026
namrataghadi-galileo
enabled auto-merge (squash)
October 6, 2026 00:42
wrisa
approved these changes
Oct 6, 2026
namrataghadi-galileo
deleted the
feature/SAO-18049-add-children-to-step
branch
October 6, 2026 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
childrento the provider-neutral runtimeStepmodel.evaluate_controls()so trace and session evaluators can inspect the complete tree.Scope
evaluate_controls()acceptschildren: list[Step] | None. Child steps retain their structured fields and can contain nested children.Nonechildren are excluded from serialization to preserve legacy payloads.@controlbehavior and trace/session lifecycle handling are unchanged. No provider-specific fields or logic were added.Risk and Rollout
Testing
make checkwas not run: dependency resolution against the configured package index failed with HTTP 403.test_client_context_manager, which requires a server athttp://localhost:8000that was not running.Checklist