Declare the debug feature required by the planets example - #80
Closed
SindSieEcht wants to merge 1 commit into
Closed
SindSieEcht wants to merge 1 commit into
SindSieEcht wants to merge 1 commit into
Conversation
planets.rs uses BigSpaceDebugPlugins, which is gated behind the debug feature, but the example only declares required-features = ["camera"]. cargo run --example planets --features camera therefore fails to compile with E0433 rather than being skipped. Same class of defect as #79.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/planets.rsusesBigSpaceDebugPlugins, which is gated behind thedebugfeature, but the example's manifest entry only declaresrequired-features = ["camera"].cargo run --example planets --features cameratherefore fails to compile with E0433 instead of being skipped:One-line manifest fix, same class of defect as #79 (which covers the
errorexample). Verified onbevy-0.19at 5f25522: with this changecargo run --example planets --features camera,debugbuilds and opens a window.