Repository navigation
[Go] Escape control characters as \u00XX in generated flyweight JSON strings - #1193
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
…strings. Get<X>AsJsonEscapedString wrote control characters with %x, which dropped the escape and lost the value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated flyweight
Get<X>AsJsonEscapedStringwrote control characters with%x, so"a\x01b"becamea1b: the escape was dropped and the value lost. It now writes them as\u00XX, which round-trips through a JSON parser.Part of #969.
Verified: TestJsonEscapedStringEscapesControlCharacters fails on master (
a1\"b1f) and passes here; sbe-tool checkstyle and test, verifyJavaIrCodecsInSync, sbe-samples check and gocodemakepass.