Repository navigation
[Go] Escape single char fields in generated flyweight String output - #1190
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
A single char field is written as a JSON string with quote and backslash escaped and control characters as \u00XX, as the C++ display now does. Do not go back to formatting the byte with %c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated flyweight
String()formatted a single char field with%cbetween quotes, so a quote, backslash or control byte broke the JSON. It now writes quote and backslash escaped and control characters as\u00XX, mirroring the C++ display fix, including inside repeating groups.Part of #969.
Verified:
TestSingleCharFieldsRenderAsValidJsonfails on master for quote, backslash, newline and control bytes (invalid JSON ... "code": """) and passes here; checkstyle,:sbe-tool:test,verifyJavaIrCodecsInSync,:sbe-samples:checkandgocodemakepass.