Repository navigation
[C++] Skip the OTF var data length prefix check for var data absent at the acting version - #1186
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
…t the acting version. An absent var data field has no length prefix on the wire, so the check must stay behind isPresent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OtfMessageDecoder::decodeData checked that a var data length prefix fits in the buffer even for a var data field added after the acting version, which has no prefix on the wire. A valid older-version message that ends where that field would start was rejected with "length too short for data length field".
The check now applies only to var data present at the acting version. Absent var data is still reported to onVarData with length 0, as the Java OtfMessageDecoder does. This is a correctness fix, not a bounds fix.
Part of #969.
Verified: OtfAbsentVarDataTest fails on master (decoding a version 0 AddVarDataV1 throws) and passes here; sbe-tool checkstyle and test, cppbuild and cppbuild --debug-build --sanitise-build pass.