Skip to content

Dark theme: login (recreating #687)#692

Open
Marc-Andrieu wants to merge 3 commits into
dark/corefrom
dark/login
Open

Dark theme: login (recreating #687)#692
Marc-Andrieu wants to merge 3 commits into
dark/corefrom
dark/login

Conversation

@Marc-Andrieu

Copy link
Copy Markdown
Member

Description

Summary

(due to some incredible GitHub bug, force-pushing to #687... closed it irrevocably... so rebasing is forbidden now i guess?!)

See #671

image image

(NB: don't criticize this sand color itself, it's an arbitrary choice that we can change when you want with 1 line)

image image

Required PRs

Depends on #671

Changes Made

  • login
    • components
      • background_painter
      • sign_in_up_bar
    • web
      • left_panel
      • right_panel
      • web_sign_in
    • app_sign_in
    • auth_page

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a local client using a pre-prod backend
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • // Comments
  • No documentation needed

@Marc-Andrieu Marc-Andrieu self-assigned this Jun 22, 2026
@Marc-Andrieu Marc-Andrieu added enhancement New feature or request ready for review This PR is ready to be reviewed login labels Jun 22, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.61%. Comparing base (98470c7) to head (9926688).

Additional details and impacted files
@@            Coverage Diff             @@
##           dark/core     #692   +/-   ##
==========================================
  Coverage      50.61%   50.61%           
==========================================
  Files            169      169           
  Lines           3839     3839           
==========================================
  Hits            1943     1943           
  Misses          1896     1896           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request login ready for review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants