Update to connectionName for database session and rename 'postgres' to 'pg' - #76
Open
rayfadh wants to merge 2 commits into
Open
Update to connectionName for database session and rename 'postgres' to 'pg'#76rayfadh wants to merge 2 commits into
connectionName for database session and rename 'postgres' to 'pg'#76rayfadh wants to merge 2 commits into
Conversation
`connection` is now `connectionName` based on `DatabaseStoreConfig` interface from @adonisjs/session package.
The stubs from starter kits are default to 'pg' instead of 'postgres'.
connectionName for database session and rename 'postgres' to 'pg'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
N/A.
❓ Type of change
📚 Description
connectionis nowconnectionNamebased onDatabaseStoreConfiginterface from @adonisjs/session package.https://github.com/adonisjs/session/blob/7c2d88917c3ed678b982def80b9701d11fb0f866/src/types.ts#L291-L292
Also, renamed the
connectionNameexample from 'postgres' to 'pg' since the stubs from the starter kits are set default to 'pg'.api starter kit:
https://github.com/adonisjs/starter-kits/blob/ba295f476e1880b893d88952e625ab2d1d80bc98/api/config/database.ts#L51-L55
api-monorepo starter kit:
https://github.com/adonisjs/starter-kits/blob/ba295f476e1880b893d88952e625ab2d1d80bc98/api-monorepo/apps/backend/config/database.ts#L51-L55
inertia-react starter kit:
https://github.com/adonisjs/starter-kits/blob/ba295f476e1880b893d88952e625ab2d1d80bc98/inertia-react/config/database.ts#L42-L46
inertia-vue starter kit:
https://github.com/adonisjs/starter-kits/blob/ba295f476e1880b893d88952e625ab2d1d80bc98/inertia-vue/config/database.ts#L42-L46
hypermedia starter kit:
https://github.com/adonisjs/starter-kits/blob/ba295f476e1880b893d88952e625ab2d1d80bc98/hypermedia/config/database.ts#L35-L39
📝 Checklist