fix(edge-deploy): queue routing-validation against all non-pattern suggestions - #3307
Open
jindaliiita wants to merge 1 commit into
Open
jindaliiita wants to merge 1 commit into
jindaliiita wants to merge 1 commit into
Conversation
…ggestions The deploy-time job pre-creation previously only ran for pattern deploys (scoped to highImpactSuggestionIds) and skipped plain deploys entirely. Now queues against every non-pattern (concrete, fetchable-URL) suggestion actually deploying, for both pattern and plain deploys, falling back to highImpactSuggestionIds only when every deployed suggestion is pattern-based -- same fallback rule llmo-experimentation-engine applies when it creates the job itself, so whichever side gets there first picks the same target set.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploySuggestionToEdgepreviously only ran for pattern deploys (scoped tometadata.highImpactSuggestionIds) and skipped plain deploys entirely.highImpactSuggestionIdsonly when every deployed suggestion is pattern-based.llmo-experimentation-engineapplies when it creates the job itself (adobe-rnd/llmo-experimentation-engine#90), so whichever side gets there first picks the same target set.Test plan
eslintclean on changed filesmocha test/controllers/suggestions.test.js— 601 passing