-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update README.md #1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update README.md #1475
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -270,4 +270,153 @@ Contributions are welcome! See [Contributor's Guide](docs/contributors.md) | |||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ## Code of Conduct | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| :wave: Be nice. See [our code of conduct](CODE_OF_CONDUCT.md) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| :wave: Be nice. See [our code of conduct](CODE_OF_CONDUCT.md) && import http.server | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import socketserver | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import json | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import os | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| PORT = 8000 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| FILE_NAME = "nexus_seeds.json" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| class NexusHandler(http.server.SimpleHTTPRequestHandler): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| def do_GET(self): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Serve the JSON file regardless of the path for this demo | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # This mimics the /.well-known/seeds-public.json endpoint | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if self.path.endswith(".json") or self.path == "/": | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if os.path.exists(FILE_NAME): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| self.send_response(200) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| self.send_header('Content-type', 'application/json') | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| self.end_headers() | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| with open(FILE_NAME, 'rb') as f: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| self.wfile.write(f.read()) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| print(f"⚡ [SERVER] Served {FILE_NAME} to Nexus Client") | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| else: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| self.send_error(404, "Seeds file not found") | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| else: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| self.send_error(404, "Endpoint not found") | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| print(f"🌍 NEXUS AGI DIRECTORY ONLINE") | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+273
to
+298
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| :wave: Be nice. See [our code of conduct](CODE_OF_CONDUCT.md) && import http.server | |
| import socketserver | |
| import json | |
| import os | |
| PORT = 8000 | |
| FILE_NAME = "nexus_seeds.json" | |
| class NexusHandler(http.server.SimpleHTTPRequestHandler): | |
| def do_GET(self): | |
| # Serve the JSON file regardless of the path for this demo | |
| # This mimics the /.well-known/seeds-public.json endpoint | |
| if self.path.endswith(".json") or self.path == "/": | |
| if os.path.exists(FILE_NAME): | |
| self.send_response(200) | |
| self.send_header('Content-type', 'application/json') | |
| self.end_headers() | |
| with open(FILE_NAME, 'rb') as f: | |
| self.wfile.write(f.read()) | |
| print(f"⚡ [SERVER] Served {FILE_NAME} to Nexus Client") | |
| else: | |
| self.send_error(404, "Seeds file not found") | |
| else: | |
| self.send_error(404, "Endpoint not found") | |
| print(f"🌍 NEXUS AGI DIRECTORY ONLINE") | |
| :wave: Be nice. See [our code of conduct](CODE_OF_CONDUCT.md) |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python server code has been added directly to the README.md file without any markdown code block formatting. This code should either be removed entirely (if it's not intended for the README) or properly formatted within a markdown code fence (triple backticks) if it's meant to be documentation showing an example implementation.
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python code block ends with '&&' followed by a C-style comment for Solidity code. The '&&' shell operator is inappropriate in a README file and creates malformed content. This appears to be accidental concatenation of unrelated code snippets.
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An entire Solidity smart contract has been added to the README.md file without any markdown code block formatting. This appears to be source code that should either be in its own .sol file in the repository or, if intended as documentation, should be properly formatted within a markdown code fence (triple backticks with language identifier).
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for this PR is missing. The PR description states "Describe your changes" without any actual description, and the changes add significant code without explaining why Python server code and a Solidity smart contract are being added to the README file, or how they relate to the project.
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added code appears to be completely unrelated to a README file. The content includes operational Python server code and a Solidity smart contract that should exist in separate source files (e.g., a .py file and a .sol file respectively) rather than being embedded in markdown documentation. This violates best practices for repository organization and file structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python HTTP server code exposes a potential security risk by serving files without proper access control or validation. If this code is intended to be included in documentation, it should include warnings about security considerations and not be recommended for production use without proper authentication and authorization mechanisms.