feat: Nexus Ad - #97
Open
jeydinpham wants to merge 2 commits into
Open
jeydinpham wants to merge 2 commits into
jeydinpham wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the way partner advertisements are displayed in the application by generalizing ad logic, introducing a new partner ad, and refactoring related components and props. The main changes include replacing the single Sage ad with a new
PartnerAdscomponent that shows both Sage and Nexus ads, updating prop names for clarity, and ensuring consistent ad rendering across the app. Closes #95Ad system refactor and enhancements:
Replaced the
SageAdcomponent with a newPartnerAdscomponent that displays bothSageAdand a newly introducedNexusAdcomponent, allowing for multiple partner ads to be shown together.Updated prop names from
showSageAd/showSageto the more generalshowAdsinCoreandSearchcomponents, reflecting the support for multiple ads.Updated all usages of the affected components and props across the app, including in the home and results pages, and in search results, to use the new
showAdsprop andPartnerAdscomponent.