fix: update whisper.cpp for CUDA 13.3 - #174
Draft
BestSithInEU wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Cause
CUDA 13.3 uses newer CCCL headers that no longer pull in
<cuda/iterator>transitively through<cub/cub.cuh>. The pinned v1.8.4 sources callcuda::make_strided_iteratorandcuda::make_counting_iteratorwithout including that header, causing CUDA builds to fail inargsort.cuandtop-k.cu. This was also reported in CrispASR#262.Whisper.cpp v1.8.5 is the first patch release containing the explicit iterator includes in both files.
Impact
Restores pywhispercpp source builds with CUDA 13.3 while keeping the dependency on a tagged whisper.cpp patch release.
Validation
GGML_CUDA=1 CMAKE_BUILD_PARALLEL_LEVEL=8 pip wheel --no-deps --no-cache-dir .pywhispercpp-1.5.1.dev1+gf3b74543d.d20260818-cp314-cp314-linux_x86_64.whl