Fix 500 error when fetching maven package with malformed POM#838
Open
Mahaboobunnisa123 wants to merge 1 commit intoaboutcode-org:mainfrom
Open
Fix 500 error when fetching maven package with malformed POM#838Mahaboobunnisa123 wants to merge 1 commit intoaboutcode-org:mainfrom
Mahaboobunnisa123 wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
Signed-off-by: Mahaboobunnisa123 <mdshabbi885@gmail.com>
Mahaboobunnisa123
force-pushed
the
fix/issue-197-maven-version-range
branch
from
7c1afbf to
d7d694f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #197
The 500 error was caused by unhandled exceptions during POM parsing when the POM contains a malformed version range.
Changes made
Added error handling so the error is logged gracefully instead of crashing.
Tests:
Added 1 new test file with 2 test cases that verify malformed POMs are handled gracefully without crashing.