Skip to content

update dependencies - #11

Merged
J0nasMayr merged 6 commits into
mainfrom
update-dependencies
Aug 10, 2026
Merged

update dependencies#11
J0nasMayr merged 6 commits into
mainfrom
update-dependencies

Conversation

@J0nasMayr

Copy link
Copy Markdown
Contributor

No description provided.

@J0nasMayr
J0nasMayr requested review from SirCotare and removed request for SirCotare August 5, 2026 12:28
@J0nasMayr
J0nasMayr marked this pull request as draft August 5, 2026 12:31
@J0nasMayr
J0nasMayr requested a review from SirCotare August 5, 2026 12:50
@J0nasMayr
J0nasMayr marked this pull request as ready for review August 5, 2026 12:50
@SirCotare

Copy link
Copy Markdown
Member

Looks good so far, but I would go one step further now that we already touched jspecify. But that's incomplete now.

So I would suggest to introduce archunit and jspecify (with compile check) and fully implement it. It also benefits the consumer.
You can use https://github.com/aboutbits/spring-boot-toolbox as an example. It contains both.
And I would remove the package-info files and annotate each class individually. That's the pattern we use everywhere else.

@SirCotare SirCotare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@J0nasMayr
J0nasMayr requested a review from SirCotare August 6, 2026 10:30
@J0nasMayr

Copy link
Copy Markdown
Contributor Author

@SirCotare I tested with Aichner and it seems to work fine.

@SirCotare SirCotare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J0nasMayr
J0nasMayr requested a review from SirCotare August 6, 2026 12:10

@SirCotare SirCotare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just a few things I noticed...

@SirCotare SirCotare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one more thing. rest lgtm

@J0nasMayr
J0nasMayr requested review from SirCotare and removed request for SirCotare August 10, 2026 06:30
@J0nasMayr
J0nasMayr requested a review from SirCotare August 10, 2026 06:32

@SirCotare SirCotare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

so, let's merge that and release the 1.0.0
then update the lib in the projects

@J0nasMayr
J0nasMayr merged commit c4157d9 into main Aug 10, 2026
1 check passed
@J0nasMayr
J0nasMayr deleted the update-dependencies branch August 10, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants