Skip to content

fix: honor close among HTTP connection options - #1554

Open
fhgffy wants to merge 2 commits into
abhinavsingh:developfrom
fhgffy:fix-connection-header-tokens
Open

fhgffy wants to merge 2 commits into
abhinavsingh:developfrom
fhgffy:fix-connection-header-tokens

Conversation

@fhgffy

@fhgffy fhgffy commented Oct 13, 2026

Copy link
Copy Markdown

HTTP/1.1 connections are persistent unless the Connection options contain close. Comparing the complete value with keep-alive incorrectly closes connections carrying additional options or an unrelated hop-by-hop token.

Check the comma-separated options case-insensitively, with close taking precedence. The regressions cover multiple options, an unrelated token, and a mixed-case close option.

Validation: the socket/parser test suite passes. The full Windows run has the same two failures as unmodified develop: the HTTP/2 SSL-context call and the connection-error fixture.

@pyba-chronographer pyba-chronographer Bot added the bot:chronographer:provided Used by chronographer to mark a PR as CHANGELOG provider label Oct 13, 2026
@fhgffy
fhgffy marked this pull request as ready for review October 13, 2026 17:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided Used by chronographer to mark a PR as CHANGELOG provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant