Repository navigation
Conversation
fhgffy
marked this pull request as ready for review
October 13, 2026 17:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP/1.1 connections are persistent unless the Connection options contain
close. Comparing the complete value withkeep-aliveincorrectly closes connections carrying additional options or an unrelated hop-by-hop token.Check the comma-separated options case-insensitively, with
closetaking precedence. The regressions cover multiple options, an unrelated token, and a mixed-case close option.Validation: the socket/parser test suite passes. The full Windows run has the same two failures as unmodified develop: the HTTP/2 SSL-context call and the connection-error fixture.