Skip to content

fix: derive forwarded Host from the request target - #1551

Open
fhgffy wants to merge 1 commit into
abhinavsingh:developfrom
fhgffy:fix-absolute-request-host
Open

fhgffy wants to merge 1 commit into
abhinavsingh:developfrom
fhgffy:fix-absolute-request-host

Conversation

@fhgffy

@fhgffy fhgffy commented Oct 13, 2026

Copy link
Copy Markdown

Fixes #1455.

For an absolute-form request, forward the Host from its request target, including an explicit port. A conflicting client Host must not select a different virtual host at the upstream server. Also supply Host when the client omitted it.

The change preserves explicit Host overrides and header filtering. The regression checks the serialized upstream request for both a conflicting and a missing Host.

Validation: the socket/parser test suite passes. The full Windows run has the same two failures as unmodified develop: the HTTP/2 SSL-context call and the connection-error fixture.

@pyba-chronographer pyba-chronographer Bot added the bot:chronographer:provided Used by chronographer to mark a PR as CHANGELOG provider label Oct 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided Used by chronographer to mark a PR as CHANGELOG provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect host field passed through to upstream

1 participant