Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1487.
A bracketed IPv6 host reaches the socket helper unchanged. Linux cannot resolve that spelling, so a request to an IPv6 literal fails before connecting. Remove the URI brackets at the socket boundary while preserving the parsed URL.
The regression opens a real IPv6 loopback listener. It failed with
gaierroron the original code under Linux and connects after the change.Validation: the socket/parser test suite passes. The full Windows run has the same two failures as unmodified develop: the HTTP/2 SSL-context call and the connection-error fixture.