Repository navigation
Conversation
webknjaz
reviewed
Oct 8, 2026
webknjaz
reviewed
Oct 8, 2026
| import pytest | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) # type: ignore[misc] |
Author
There was a problem hiding this comment.
This was also taken from existing tests, but the problem still exists:
tests/conftest.py:16: error: Untyped decorator makes function "_event_loop_before_mocks" untyped [misc]
Contributor
There was a problem hiding this comment.
Okay, then it makes sense to leave a comment explaining when it's fine to drop the ignore.
Author
There was a problem hiding this comment.
AFAIK the unused ignore should report its own warning.
Contributor
There was a problem hiding this comment.
But this means that I order to learn what the problem was, one would have to
- Clone the repo
- Set up the dev env
- Remove the ignore
- Run MyPy
- Contemplate on the reasons for not fixing the underlying problem
- Recover the type ignore
- Repeat for each unexplained suppression
Instead, with a code comment, a reader could
- Read it
- Understand the motivation
Wouldn't it be nicer to optimize for the reader?
webknjaz
reviewed
Oct 8, 2026
webknjaz
reviewed
Oct 8, 2026
webknjaz
reviewed
Oct 8, 2026
This requires to initialize the `asyncio` event loop before other fixtures to keep some of the tests working. Signed-off-by: Jakub Jelen <jjelen@redhat.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.