fix(settings): defer profile selection persistence until save - #141
fix(settings): defer profile selection persistence until save#141jgindin wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the settings view to handle profile selection locally as a draft state (draftSelectedProfileId) rather than committing changes immediately. The actual profile selection is now only saved when the user explicitly clicks "Save Settings". The review feedback highlights opportunities to simplify the code by removing an unnecessary queueMicrotask deferral, eliminating a redundant state initialization in ngOnInit(), and directly querying the profiles dictionary in onProfileSelected instead of relying on a computed signal.
⚡ A2UI Composer PR PreviewYour automated preview is successfully live (commit
|
Decouples profile dropdown selection from immediate LocalStorage and StartupResolution mutation. Profile changes in the Settings UI now update local form state only, and are persisted when saveSettings() is explicitly invoked.
5f8349c to
aef1721
Compare
1 participant
Description
Decouples profile dropdown selection from immediate LocalStorage and StartupResolution mutation. Profile changes in the Settings UI now update local form state only, and are persisted when saveSettings() is explicitly invoked.
Pre-launch Checklist