Add local readme.txt fallback for Tested up to#82
Draft
apermo wants to merge 1 commit intoZodiac1978:developfrom
Draft
Add local readme.txt fallback for Tested up to#82apermo wants to merge 1 commit intoZodiac1978:developfrom
apermo wants to merge 1 commit intoZodiac1978:developfrom
Conversation
Contributor
Author
|
@Zodiac1978 would you take over from here? If you need further assistance let me know, you should be able to push to the pr. |
for "Tested up to" Parse the "Tested up to" header from the plugin's local readme.txt when the wordpress.org API does not provide a value. This covers non-wordpress.org plugins (custom Update URI) and cases where the API returns no tested value. Closes Zodiac1978#64
apermo
force-pushed
the
fix/tested-up-to-from-readme
branch
from
78f5353 to
1782887
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_local_tested_up_to()method that parses theTested up toheader from a plugin's localreadme.txt(orreadme.md)testedvalue (e.g. non-wordpress.org plugins with customUpdate URI)esc_html()(minor hardening)Fixes #64
Context
The
Tested up tocolumn currently relies exclusively onplugins_api(). This fails for:Update URI) — no API call is made, column shows "No data available"plugins_apifiltersThe local readme.txt is the authoritative source for the installed version's compatibility declaration and serves as a reliable fallback.
Test in WordPress Playground
Before (develop — no fallback): Open in WordPress Playground
After (this branch — readme.txt fallback): Open in WordPress Playground
Pre-installed test plugins: Apermo Admin Bar (outdated), giWeather (closed/removed)
Test plan