update libCZI-version to 0.67.0, enable mask-support#15
Merged
ptahmose merged 7 commits intoZEISS:mainfrom Sep 23, 2025
Merged
Conversation
Enhanced `AccessorOptions` to support mask-aware composition by introducing the `MaskAwareness` key in the new static class `AccessorOptionsAdditionalOptionsKeys`. Refactored the `SingleChannelTileAccessorGet` method to handle additional options via JSON serialization using `System.Text.Json`. Added the utility method `AccessorAdditionalOptionsJsonFromPropertyBag` to serialize the `AdditionalOptionsPropertyBag` into a UTF-8 JSON byte array. Updated the build system (`build_libCZIAPI.yml`) to include the `-DADDITIONAL_LIBS_REQUIRED_FOR_ATOMIC` CMake variable for atomic operation support. Made minor formatting adjustments for consistency.
Updated the `build_libCZIAPI.yml` file to explicitly define the `-DADDITIONAL_LIBS_REQUIRED_FOR_ATOMIC` variable as an empty value during the `cmake` build process. This change ensures the variable is defined to prevent potential build issues or warnings related to undefined variables.
Updated `using` directives across multiple files to use fully qualified namespaces for `Zeiss.Micro.LibCzi.Net.Interface` and `Zeiss.Micro.LibCzi.Net.Interop`. - Replaced shorthand `using Interface;` and `using Interop;` with fully qualified counterparts in `Attachment.cs`, `Bitmap.cs`, `CziDocumentInfo.cs`, `DisplaySettings.cs`, and `InputStream.cs`. - Updated `StreamClassesRepository.cs` to use `Zeiss.Micro.LibCzi.Net.Interop`. - Updated `Factory.cs` to use `Zeiss.Micro.LibCzi.Net.Implementation` and `Zeiss.Micro.LibCzi.Net.Interop`. These changes improve code clarity, reduce ambiguity, and align with best practices for namespace usage.
Updated `using` directives across multiple files to use fully qualified namespaces (`Zeiss.Micro.LibCzi.Net.Interface` and `Zeiss.Micro.LibCzi.Net.Interop`) for improved clarity and to avoid potential namespace conflicts. Removed implicit imports (`Interface` and `Interop`) from the `Implementation` namespace. Changed `SafeBufferOnNativeMemory` class to `sealed` to prevent inheritance. Removed unused `using` directives in several files (e.g., `System.Text` in `SubBlock.cs` and `VersionInfo.cs`) to improve code hygiene. Eliminated all `using` directives in `VersionInfo.cs` as they were no longer needed. Added explicit `using Zeiss.Micro.LibCzi.Net.Implementation;` in `LibCziApiInterop.cs` to include the `Implementation` namespace explicitly.
Two new test methods were added to `AccessorTests.cs`: - `SingleChannelScalingTileAccessorWithMaskGray8Scenario1MaskAware` tests behavior with mask awareness enabled. - `SingleChannelScalingTileAccessorWithMaskGray8Scenario1MaskUnaware` tests behavior with mask awareness disabled. Both tests validate the output of a 6x6 bitmap under different mask-awareness settings, ensuring correct handling of overlapping sub-blocks. Proper locking and unlocking of the bitmap are verified. The `version.txt` file was updated from `0.0.23` to `0.1.0` to reflect the addition of new functionality.
DaveyJonesBitPail
approved these changes
Sep 23, 2025
Collaborator
DaveyJonesBitPail
left a comment
DaveyJonesBitPail
left a comment
There was a problem hiding this comment.
Approved w/ suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates libCZI to latest version (0.67.0), which adds support for "mask-aware tile-composition"
AdditionalOptionsPropertyBaginISingleChannelTileAccessor.Fixes # (issue)
Type of change
How Has This Been Tested?
with the unit-test
Checklist: